From: Keir Fraser Date: Thu, 2 Apr 2009 12:02:13 +0000 (+0100) Subject: x86: imply 'noapic' from 'nolapic' X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~13989^2~9 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=e295a5ce4b7bb2b8f774fbc576bab45ab6663bc9;p=xen.git x86: imply 'noapic' from 'nolapic' While in the comments to an earlier submitted (and already applied) patch I claimed to have fixed the need to specify both "nolapic" and "noapic" when "nolapic" alone should already have the intended effect, this doesn't appear to be the case. Here are the missing bits. Signed-off-by: Jan Beulich --- diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index 2bbb003eaa..aab68048eb 100644 --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -1303,8 +1303,10 @@ int __init APIC_init_uniprocessor (void) if (enable_local_apic < 0) clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); - if (!smp_found_config && !cpu_has_apic) + if (!smp_found_config && !cpu_has_apic) { + skip_ioapic_setup = 1; return -1; + } /* * Complain if the BIOS pretends there is one. @@ -1313,6 +1315,7 @@ int __init APIC_init_uniprocessor (void) printk(KERN_ERR "BIOS bug, local APIC #%d not detected!...\n", boot_cpu_physical_apicid); clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); + skip_ioapic_setup = 1; return -1; }